Mount editor at /app (Multi-Zones) + finish OpenScript rebrand#4
Merged
Conversation
Renames functional identifiers that still carried the upstream name: - ESLint plugin eslint-plugin-opencut -> -openscript and rule opencut/prefer-object-params -> openscript/prefer-object-params (incl. all eslint-disable directives that reference it) - Postgres dev DB user/pass/name opencut -> openscript across docker-compose.yml, .env.example, Dockerfile, bun-ci.yml, CONTRIBUTING.md - Cloudflare worker name/service opencut -> openscript (both wrangler.jsonc) - Desktop crate opencut-desktop -> openscript-desktop - website accent-color comment Intentionally left unchanged: the published `opencut-wasm` npm package (+ opencut_wasm.* filenames) and the opencut-* localStorage keys, whose rename would break the dependency / orphan existing users' stored data.
Marketing site (apps/website) is the default zone serving "/"; the editor (apps/web) now ships under basePath "/app" and is stitched in via rewrites, so the whole product is one origin: landing at "/", editor at "/app". - apps/web: basePath "/app" (also namespaces /_next under /app) - apps/website: rewrites /app and /app/:path* -> APP_ZONE_URL - BASE_PATH constant; auth baseURL (client+server) and the feedback fetch now resolve under /app (next/link & next/navigation are already basePath-aware) - hero CTA: 'Join Waitlist' -> 'Launch the beta' (/app); waitlist kept as a secondary link; /success demo link now points at /app - remove the superseded mock /editor demo (page + components) Both apps build green; editor type-checks clean. Auth/feedback are optional backend features (no DB/Redis in the beta) so their basePath wiring is correct but unexercised until that backend is deployed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 33826069 | Triggered | Generic Password | ef86e26 | docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pre-launch cleanup + makes the beta reachable as one site.
1. Mount the editor at
/app(Next.js Multi-Zones)The marketing site (
apps/website) is the default zone serving/; the editor (apps/web) now ships withbasePath: "/app"and is stitched in via rewrites — so the whole product is one origin: landing at/, editor at/app.apps/web:basePath: "/app"(also namespaces/_nextunder/app)apps/website: rewrites/appand/app/:path*→APP_ZONE_URLBASE_PATHconstant; authbaseURL(client + server) and the feedbackfetchnow resolve under/app(next/link&next/navigationare already basePath-aware)/app); waitlist kept as a secondary link;/successdemo link now points at/app/editordemo (page + 6 components, ~900 lines)2. Finish the OpenCut → OpenScript rebrand
Renames functional identifiers that still carried the upstream name:
eslint-plugin-opencut→-openscriptand ruleopencut/prefer-object-params→openscript/...(incl. alleslint-disabledirectives)opencut→openscript(docker-compose,.env.example, Dockerfile,bun-ci.yml, CONTRIBUTING)openscript(bothwrangler.jsonc)opencut-desktop→openscript-desktopIntentionally left unchanged: the published
opencut-wasmnpm package (+opencut_wasm.*filenames) and theopencut-*localStorage keys — renaming would break the dependency / orphan existing users' stored data.Verification
apps/webbuilds green withbasePath: "/app";tsc --noEmitcleanapps/websitebuilds green (routes:/,/_not-found,/success)Once merged and deployed, the editor stops serving at root and only answers under
/app. These must land together with the merge or the live editor breaks:apps/websiteas the front-door project (what the domain points at).APP_ZONE_URLon the marketing project = the editor deployment's URL (the/app/*rewrite target).openscript.appDNS at the marketing project.Known follow-ups (non-blocking)
apps/desktopremains a non-functional GPUI scaffold (no "download").